-
Notifications
You must be signed in to change notification settings - Fork 91
Add function for accessing underlying PKCS#11 keys #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add a function to allow users of this package to access underlying PKCS#11-isms so that custom extensions can be built. For example the new function could be used to wrap/export a key or unwrap/import a key using the handle associated with an existing private or secret key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm interested in this PR as well. @solcates seems like you are the only reviewer. Are there any reviewers with write access to the repo left or is it not possible to merge any PR anymore? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Seems my write access has disappeared since leaving Thales. Anyone else able to help here? |
Hi Nick @nickrmc83 Do you still intend to merge this PR? I look forward to using the feature you added. This PR needs a rebase though. I'll make a duplicate PR with the same changes if you're no longer working on crypto11. |
Working on it |
I am unfortunately not a maintainer of this project any more. We'll need someone else to approve the merge. |
Hi @nickrmc83, Thank you for your reply ! Are you still active on this PR ? |
I think @nickrmc83 and I are still active users and happy to add PR, but we do not have the right permissions to approve or merge things it seems. We both are former Thales employees, but would be willing to help out a bit with permissions. |
I can look at merging master into this branch. It'll likely be in a couple of weeks though. |
Add a function to allow users of this package to access underlying PKCS#11-isms so that custom extensions can be built. For example the new function could be used to wrap/export a key or unwrap/import a key using the handle associated with an existing private or secret key.